Added/Corrected logging of all caught Exceptions #27033

1 files changed, 6 insertions, 8 deletions

diff --git a/src/main/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/controller/CreateCarController.java b/src/main/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/controller/CreateCarController.java
index 9272050..37699df 100644
--- a/src/main/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/controller/CreateCarController.java
+++ b/src/main/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/controller/CreateCarController.java
@@ -8,7 +8,6 @@ import at.ac.tuwien.sepm.assignment.groupphase.einsatzverwaltung.service.Vehicle
 import at.ac.tuwien.sepm.assignment.groupphase.exception.InvalidVehicleException;
 import at.ac.tuwien.sepm.assignment.groupphase.exception.ServiceException;
 import java.io.IOException;
-import java.lang.invoke.MethodHandles;
 import java.util.EnumSet;
 import java.util.Set;
 import java.util.stream.Collectors;
@@ -41,7 +40,7 @@ public class CreateCarController {
     @FXML private FlowPane fpVehicleList;
     private final CreateOperationController createOperationController;
 
-    private static final Logger LOG = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+    private static final Logger LOG = LoggerFactory.getLogger(CreateCarController.class);
     private final VehicleService vehicleService;
     private boolean update = false;
     private long vid = -1;
@@ -100,12 +99,12 @@ public class CreateCarController {
                 vehicleService.add(vehicle);
                 setToStart();
             } catch (InvalidVehicleException e) {
-                LOG.error("Invalid Vehicle: {}", e);
+                LOG.debug("Validation of Vehicle failed");
                 createComplete(AlertType.ERROR, "Ungültige Eingabe", e.getMessage());
                 setToStart();
                 return;
             } catch (ServiceException e) {
-                LOG.error("Exception: {}", e);
+                LOG.error("ServiceException in createCar(). ", e);
                 createComplete(AlertType.ERROR, "Fehler", e.getMessage());
                 setToStart();
                 return;
@@ -129,13 +128,12 @@ public class CreateCarController {
                 setToStart();
                 chooseVehicle = null;
             } catch (InvalidVehicleException e) {
-                // TODO: Validation-Errors should be logged with log level debug only (like here)
-                LOG.debug("Invalid Vehicle: {}", e);
+                LOG.debug("Validation of Vehicle failed");
                 createComplete(AlertType.ERROR, "Ungültige Eingabe", e.getMessage());
                 setToStart();
                 return;
             } catch (ServiceException e) {
-                LOG.error("Exception: {}", e);
+                LOG.error("ServiceException in createCar(). ", e);
                 createComplete(AlertType.ERROR, "Fehler", e.getMessage());
                 setToStart();
                 return;
@@ -233,7 +231,7 @@ public class CreateCarController {
                 fpVehicleList.getChildren().add(controller.getRootElement());
             }
         } catch (ServiceException | IOException e) {
-            LOG.error("Error while updating list.", e);
+            LOG.error("Exception in updateVehiclePane(). ", e);
 
             Alert alert = new Alert(AlertType.ERROR);
             alert.setTitle("Fehler");