Refactor EmployeeServiceTest to use a single builder [#25963]

1 files changed, 12 insertions, 23 deletions

diff --git a/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/service/EmployeeServiceTest.java b/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/service/EmployeeServiceTest.java
index c6b1423..9f7a965 100644
--- a/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/service/EmployeeServiceTest.java
+++ b/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/service/EmployeeServiceTest.java
@@ -22,6 +22,14 @@ public class EmployeeServiceTest {
     private final EmployeeDAO employeePersistence = mock(EmployeeDatabaseDao.class);
     private final EmployeeService employeeService = new EmployeeServiceImpl(employeePersistence);
 
+    private final Employee.Builder employeeBuilder =
+            Employee.builder()
+                    .name("Testperson")
+                    .birthday(LocalDate.parse("1996-10-10"))
+                    .educationLevel(EducationLevel.NKA)
+                    .isDriver(true)
+                    .isPilot(false);
+
     public EmployeeServiceTest() throws PersistenceException {
         when(employeePersistence.add(any())).thenReturn(1L);
     }
@@ -29,14 +37,7 @@ public class EmployeeServiceTest {
     @Test
     public void testAddValidEmployee() {
 
-        Employee employee =
-                Employee.builder()
-                        .name("Testperson")
-                        .birthday(LocalDate.MIN)
-                        .educationLevel(EducationLevel.NA)
-                        .isDriver(true)
-                        .isPilot(false)
-                        .build();
+        Employee employee = employeeBuilder.build();
 
         try {
             Assert.assertThat(employeeService.add(employee), is(1L));
@@ -46,21 +47,9 @@ public class EmployeeServiceTest {
     }
 
     @Test(expected = InvalidEmployeeException.class)
-    public void testAddInvalidEmployee() throws InvalidEmployeeException {
-
-        Employee employee =
-                Employee.builder()
-                        .name("")
-                        .birthday(LocalDate.MIN)
-                        .educationLevel(EducationLevel.NA)
-                        .isDriver(true)
-                        .isPilot(false)
-                        .build();
+    public void testAddInvalidEmployee() throws InvalidEmployeeException, ServiceException {
 
-        try {
-            employeeService.add(employee);
-        } catch (ServiceException e) {
-            fail();
-        }
+        Employee employee = employeeBuilder.name("").build();
+        employeeService.add(employee);
     }
 }