Change interfaces to use Set instead of List

4 files changed, 18 insertions, 18 deletions

diff --git a/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/dao/RegistrationDatabaseDAOTest.java b/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/dao/RegistrationDatabaseDAOTest.java
index 03059ff..09699c5 100644
--- a/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/dao/RegistrationDatabaseDAOTest.java
+++ b/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/dao/RegistrationDatabaseDAOTest.java
@@ -11,8 +11,8 @@ import java.nio.charset.Charset;
 import java.sql.SQLException;
 import java.time.Instant;
 import java.time.LocalDate;
-import java.util.LinkedList;
-import java.util.List;
+import java.util.HashSet;
+import java.util.Set;
 import org.h2.tools.RunScript;
 import org.junit.AfterClass;
 import org.junit.BeforeClass;
@@ -79,7 +79,7 @@ public class RegistrationDatabaseDAOTest {
 
     @Test
     public void addRegistrationsShouldSucceed() throws PersistenceException {
-        List<Registration> registrations = new LinkedList<>();
+        Set<Registration> registrations = new HashSet<>();
         /*
         Vehicle vehicle = Vehicle.builder()
                 .id(1)
@@ -139,14 +139,14 @@ public class RegistrationDatabaseDAOTest {
         registrations.add(registration2);
         registrations.add(registration3);
 
-        List<Long> returnvalues = registrationDAO.add(1, registrations);
+        Set<Long> returnvalues = registrationDAO.add(1, registrations);
         assertFalse(returnvalues.isEmpty()); // can be improved...
     }
 
     @Test
     public void addRegistrationToInexistentVehicleShouldFail() throws PersistenceException {
         thrown.expect(PersistenceException.class);
-        List<Registration> registrations = new LinkedList<>();
+        Set<Registration> registrations = new HashSet<>();
         Employee employee =
                 Employee.builder()
                         .id(1)
diff --git a/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/service/RegistrationServiceImplTest.java b/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/service/RegistrationServiceImplTest.java
index 88642ee..95d8d77 100644
--- a/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/service/RegistrationServiceImplTest.java
+++ b/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/einsatzverwaltung/service/RegistrationServiceImplTest.java
@@ -21,8 +21,8 @@ import at.ac.tuwien.sepm.assignment.groupphase.exception.ServiceException;
 import java.time.Instant;
 import java.time.LocalDate;
 import java.time.temporal.ChronoUnit;
-import java.util.LinkedList;
-import java.util.List;
+import java.util.HashSet;
+import java.util.Set;
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
@@ -60,7 +60,7 @@ public class RegistrationServiceImplTest {
             throws InvalidRegistrationException, ServiceException, InvalidVehicleException {
         RegistrationService registrationService =
                 new RegistrationServiceImpl(registrationDAO, vehicleDAO);
-        List<Registration> registrations = new LinkedList<>();
+        Set<Registration> registrations = new HashSet<>();
         Vehicle vehicle =
                 Vehicle.builder()
                         .id(1)
@@ -117,7 +117,7 @@ public class RegistrationServiceImplTest {
         thrown.expect(InvalidRegistrationException.class);
         RegistrationService registrationService =
                 new RegistrationServiceImpl(registrationDAO, vehicleDAO);
-        List<Registration> registrations = new LinkedList<>();
+        Set<Registration> registrations = new HashSet<>();
         Vehicle vehicle =
                 Vehicle.builder()
                         .id(1)
diff --git a/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/employee/EmployeePersistenceTest.java b/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/employee/EmployeePersistenceTest.java
index e8d0d4d..5099976 100644
--- a/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/employee/EmployeePersistenceTest.java
+++ b/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/employee/EmployeePersistenceTest.java
@@ -9,7 +9,7 @@ import at.ac.tuwien.sepm.assignment.groupphase.util.JDBCConnectionManager;
 import java.io.InputStream;
 import java.sql.Types;
 import java.time.LocalDate;
-import java.util.List;
+import java.util.Set;
 import org.dbunit.DBTestCase;
 import org.dbunit.PropertiesBasedJdbcDatabaseTester;
 import org.dbunit.database.DatabaseConfig;
@@ -69,7 +69,7 @@ public class EmployeePersistenceTest extends DBTestCase {
     }
 
     public void testListEmployees() throws PersistenceException {
-        List<Employee> employees = employeePersistence.list();
+        Set<Employee> employees = employeePersistence.list();
 
         System.out.println(LocalDate.parse("2010-10-10"));
         Employee empOne =
@@ -109,7 +109,7 @@ public class EmployeePersistenceTest extends DBTestCase {
     }
 
     public void testEmployeeListNoElement() throws PersistenceException {
-        List<Employee> employees = employeePersistence.list();
+        Set<Employee> employees = employeePersistence.list();
 
         Employee empOne =
                 Employee.builder()
diff --git a/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/operation/OperationServiceUnitTest.java b/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/operation/OperationServiceUnitTest.java
index fc10553..2b1e2f0 100644
--- a/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/operation/OperationServiceUnitTest.java
+++ b/src/test/java/at/ac/tuwien/sepm/assignment/groupphase/operation/OperationServiceUnitTest.java
@@ -19,7 +19,7 @@ import at.ac.tuwien.sepm.assignment.groupphase.exception.InvalidOperationExcepti
 import at.ac.tuwien.sepm.assignment.groupphase.exception.PersistenceException;
 import at.ac.tuwien.sepm.assignment.groupphase.exception.ServiceException;
 import java.time.Instant;
-import java.util.List;
+import java.util.Set;
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -51,7 +51,7 @@ public class OperationServiceUnitTest {
                         .destination("Wiedner Hauptstraße 35, Wien")
                         .additionalInfo("HTU Wien")
                         .severity(Severity.B)
-                        .vehicles(List.of(vehicle))
+                        .vehicles(Set.of(vehicle))
                         .build();
         try {
             Assert.assertThat(operationService.add(operation), is(1L));
@@ -87,7 +87,7 @@ public class OperationServiceUnitTest {
                         .destination("Wiedner Hauptstraße 35, Wien")
                         .additionalInfo("HTU Wien")
                         .severity(Severity.B)
-                        .vehicles(List.of(vehicle, vehicle1))
+                        .vehicles(Set.of(vehicle, vehicle1))
                         .build();
         try {
             Assert.assertThat(operationService.add(operation), is(1L));
@@ -106,7 +106,7 @@ public class OperationServiceUnitTest {
                         .destination("Wiedner Hauptstraße 35, Wien")
                         .additionalInfo("HTU Wien")
                         .severity(Severity.B)
-                        .vehicles(List.of())
+                        .vehicles(Set.of())
                         .build();
         try {
             Assert.assertThat(operationService.add(operation), is(1L));
@@ -125,7 +125,7 @@ public class OperationServiceUnitTest {
                         .destination("")
                         .additionalInfo("HTU Wien")
                         .severity(Severity.B)
-                        .vehicles(List.of())
+                        .vehicles(Set.of())
                         .build();
         try {
             Assert.assertThat(operationService.add(operation), is(1L));
@@ -144,7 +144,7 @@ public class OperationServiceUnitTest {
                         .destination("Römergasse 7, 2500 Baden")
                         .additionalInfo("HTU Wien")
                         .severity(Severity.B)
-                        .vehicles(List.of())
+                        .vehicles(Set.of())
                         .build();
         try {
             Assert.assertThat(operationService.add(operation), is(1L));